This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@eric-haibin-lin @apeforest @ptrendx could you help take a look? Thanks! |
@mxnet-label-bot add[Module, Optimizer, Python, pr-awaiting-review] |
marcoabreu
added
Module
Optimizer
pr-awaiting-review
PR is waiting for code review
Python
labels
Feb 21, 2019
ptrendx
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incidentally, update in Gluon already does the right thing: https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/gluon/trainer.py#L429
ChaiBapchya
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for that deep dive (finding the bug) and then resolving it!
jessr92
pushed a commit
to jessr92/incubator-mxnet
that referenced
this pull request
Feb 28, 2019
jessr92
pushed a commit
to jessr92/incubator-mxnet
that referenced
this pull request
Feb 28, 2019
jessr92
pushed a commit
to jessr92/incubator-mxnet
that referenced
this pull request
Feb 28, 2019
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Mar 4, 2019
vdantu
pushed a commit
to vdantu/incubator-mxnet
that referenced
this pull request
Mar 31, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #14216
see detailed analysis in the issue.
I added a unit test although this may not be a common/correct use case in MXNet.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
add check for empty list
Comments